Re: S+core architecture (arch/score/) support files
From: liqin . chen
Date: Tue Jun 23 2009 - 06:57:23 EST
Arnd Bergmann <arnd@xxxxxxxx> 写于 2009-06-23 17:43:22:
> On Tuesday 23 June 2009, liqin.chen@xxxxxxxxxxxxx wrote:
> > Hi Linus,
> > This repository contains Linux support for S+core CPU.
> > Please pull
> > git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git
> I've helped Liquin getting this into a state for inclusion,
> so I'll share my observations about the submission.
> The code looks very clean for a new architecture support, with the
> exception of a few misformatted comments and similar minor issues.
> By using the asm-generic headers that are now in 2.6.31, the amount
> of copy-paste programming was reduced to a minimum, the total amount
> of code added is much less than any other architecture (200kb score,
> 290kb h8300, 570kb microblaze are the smallest ones).
> Fixes for any issues noted during review usually came in quickly.
> S+core is now the first architecture to use the ABI defined in
> asm-generic, which means it can serve as an example for other
> architectures that want to merge their code in the future.
> Unfortunately, I don't think that the score glibc has been fully
> ported to support this, so it also means that the version that is
> being submitted has undergone any run-time testing. I did check
> that it compiles fine but could not do more in lack of hardware
> or even just a user space distro.
> Another small negative is that Liquin is still unexperienced with
> the procedures we use in Linux. I've helped out by providing
> my git tree, but am not planning to do that beyond 2.6.31.
> Given that he has also been upstream gcc maintainer for S+core
> for well over 2 years, I believe merging it now will work out well.
With the help of Arnd, linux/score code become more and more clear.
Before we commit the code to linux.org,
Linux had run on spct6600 score platform well.
It had passed LTP test and could run many general applications.
S+core application depend on glibc-2.3.6, which support static
and dynamic applications.
We will upgrade glibc to catch up with the linux/score updating.