Re: [PATCH 3/3] net-dccp: Suppress warning about large allocationsfrom DCCP
From: Eric Dumazet
Date: Tue Jun 23 2009 - 07:05:17 EST
David Miller a écrit :
> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Date: Mon, 22 Jun 2009 23:39:36 -0300
>> Em Mon, Jun 22, 2009 at 04:15:02PM -0700, David Miller escreveu:
>>> It's probably much more appropriate to make this stuff use
>>> alloc_large_system_hash(), like TCP does (see net/ipv4/tcp.c
>>> All of this complicated DCCP hash table size computation code will
>>> simply disappear. And it'll fix the warning too :-)
>> He mentioned that in the conversation that lead to this new patch
>> series, problem is that alloc_large_system_hash is __init, so when you
>> try to load dccp.ko it will not be available.
> Fair enough.
> It's such an unfortunate duplication of code, it's likely therefore
> better to remove the __init tag and export that symbol.
Agreed, I once considered using this function for futex hash table allocation
and just forgot about it...
But it has some bootmem references, it might need more work than just exporting it.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/