Re: [PATCH 2/2 v2] Blackfin: fix dma-mapping build errors

[Mike Frysinger]

On Tue, Jun 23, 2009 at 04:40, Arnd Bergmann wrote:
> On Tuesday 23 June 2009, Mike Frysinger wrote:
>> +static inline void dma_sync_sg_for_device(struct device *dev,
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â struct scatterlist *sg,
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â int nents, enum dma_data_direction dir)
>> +{
>> +}
>
> If you flush the dcache in dma_map_sg, you probably also need to
> flush it in dma_sync_*_for_device:
>
> static inline void
> dma_sync_sg_for_device(struct device *dev, struct scatterlist *sglist,
> Â Â Â Â Â Â Â Â Â Â Âint nents, enum dma_data_direction direction)
> {
> Â Â Â struct scatterlist *sg;
> Â Â Â int i;
>
> Â Â Â for_each_sg(sglist, sg, nents, i)
> Â Â Â Â Â Â Â invalidate_dcache_range(sg_virt(sg), sg_virt(sg) + sg->length);
> }

i'll just integrate this into the patch you sent previously during the
next merge window.  these new functions werent actually being used
anywhere on Blackfin systems, so i'm not terribly worried about them
for now.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/