Re: +printk-add-printk_delay-to-make-messages-readable-for-some-scenarios.patch added to -mm tree

[Dave Young]

On Tue, Jun 23, 2009 at 09:19:44AM +0200, Ingo Molnar wrote:
> 
> two minor comments:

Thanks for your comments and andrew's fixes.

> 
> > +++ a/kernel/printk.c
> > @@ -640,6 +640,19 @@ static int recursion_bug;
> >  static int new_text_line = 1;
> >  static char printk_buf[1024];
> >  
> > +int printk_delay_msec;
> 
> should be __read_mostly.
> 
> > +
> > +static inline void printk_delay(void)
> > +{
> > +	if (unlikely(printk_delay_msec)) {
> > +		int m = printk_delay_msec;
> > +		while (m--) {
> 
> newline needed after local variable.
> 
> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/