Re: [PATCH 3/8] SFI: core support

From: Ingo Molnar
Date: Tue Jun 23 2009 - 15:20:56 EST



* Len Brown <lenb@xxxxxxxxxx> wrote:

> Re: #define PREFIX "SFI: "
>
> The SFI code uses all pr_info/debug/warning/err format
> and so it looks like the way to go is like this;
>
> #define KMSG_COMPONENT "SFI"
> #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
>
> and get rid of the PREFIX stuff in the actual messages.
> Is that the recommended way to go these days?

Yeah, overloadig pr_fmt looks entirely correct and per design. That
will make it even cleaner.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/