Re: [RFC][ PATCH -tip v2 0/7] kprobes: Kprobes jump optimizationsupport

[Masami Hiramatsu]

Ingo Molnar wrote:
>> Ingo Molnar wrote:
>>> * Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>>>
>>>> o Usage
>>>>  Set CONFIG_OPTPROBES=y when building a kernel, then all *probes will be
>>>> optimized if possible.
>>> Should be default-y if KPROBES is enabled. I.e. we really only want 
>>> to disable it to debug potential issues.
>> Sure, thanks!
> 
> Plus i'd suggest a runtime control (a sysctl) as well - if it's not 
> too intrusive. Since this is an optional speedup feature, distros 
> can have this enabled and if there's some problem with it then it 
> can still be disabled in sysctl.conf, without having to rebuild the 
> kernel.

The runtime control is a good idea. Btw, current kprobes already has
a runtime disable interface under sysfs. Is there any reason that we'd
better to use sysctl instead of sysfs?


Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/