Re: [PATCH 1/4] asm/sections: add text/data checking functions for arches to override

[Mike Frysinger]

On Tue, Jun 23, 2009 at 18:40, Andrew Morton wrote:
> On Wed, 17 Jun 2009 12:22:21 -0400 Mike Frysinger wrote:
>> Some ports (like the Blackfin arch) have a discontiguous memory map which
>> means there may be text or data that falls outside of the standard range
>> of the start/end text/data symbols. ÂCreating some helper functions allows
>> these non-standard ports to declare these regions without adversely
>> affecting anyone else.
>
> The patches look OK to me.
>
> I assumed they're for 2.6.32.

it's for whatever is easiest to merge

>> index 4ce48e8..ee19462 100644
>> --- a/include/asm-generic/sections.h
>> +++ b/include/asm-generic/sections.h
>> @@ -20,4 +20,20 @@ extern char __start_rodata[], __end_rodata[];
>> Â#define dereference_function_descriptor(p) (p)
>> Â#endif
>>
>> +/* random extra sections (if any). ÂOverride
>> + * in asm/sections.h */
>> +#ifndef arch_is_kernel_text
>> +static inline int arch_is_kernel_text(unsigned long addr)
>> +{
>> + Â Â return 0;
>> +}
>> +#endif
>> +
>> +#ifndef arch_is_kernel_data
>> +static inline int arch_is_kernel_data(unsigned long addr)
>> +{
>> + Â Â return 0;
>> +}
>> +#endif
>
> I suppose that for completeness and consistency etc really we should have
>
> #define arch_is_kernel_text arch_is_kernel_text
> #define arch_is_kernel_data arch_is_kernel_data
>
> in here.

*shrug* other places that use this style dont include these defines
for completeness as the define muck is for the header to know about
(arches providing their own version), not any source code -- they
shouldnt know anything about the ifdef stuff.  i dont care much either
way.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/