Re: [PATCH] perf stat: fix hardcoded nr_counter

[Ingo Molnar]

* Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx> wrote:

> nr_counter should be based on number of default_attrs entries.

The problem is, this will cause a _lot_ of counters to be used by 
default, overloading the PMU quite significantly and reducing 
precision. The number of hw counters is chosen intentionally the way 
it is now, so that on common hardware there's no over-commit.

As i suggested before, your change does make sense if introduced as 
extended event specifications to 'perf stat':

 -e all
 -e all-sw-counters
 -e all-hw-counters

with regex wildcard support too.

Instead, you chose to ignore my feedback and wasted my time by 
re-sending the same broken patch. If you do such things i'll have to 
start ignoring you - it is very ineffective for me to repeat every 
argument and suggestion two or more times and no other contributor 
does this ...

> Remove dead code and some code alignment.

Could you please send this separately?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/