Re: [RFC,PATCH 2/2] change __wake_up_parent() to use filtered wakeup

[Roland McGrath]

Looks good, I'm glad to see this revived.  

I note that even simpler than eligible_child() is just:

	if ((wo->wo_flags & __WNOTHREAD) && wo->child_wait.private != p->parent)
		return 0;

IIRC that is the test that Ratan's original patch used to address the
particular application usage that first troubled him.  But probably this
is already what you meant by "more clever later" (and ->parent is perhaps
not right in all cases there).

Your two patches as they are look safe and useful to me and I hope they can
go in soon.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/