Re: [PATCH 1/1] mm_for_maps: simplify, use ptrace_may_access()

[James Morris]

On Tue, 23 Jun 2009, Serge E. Hallyn wrote:

> Quoting Oleg Nesterov (oleg@xxxxxxxxxx):
> > It would be nice to kill __ptrace_may_access(). It requires task_lock(),
> > but this lock is only needed to read mm->flags in the middle.
> > 
> > Convert mm_for_maps() to use ptrace_may_access(), this also simplifies
> > the code a little bit.
> > 
> > Also, we do not need to take ->mmap_sem in advance. In fact I think
> > mm_for_maps() should not play with ->mmap_sem at all, the caller should
> > take this lock.
> 
> Yeah I think that makes sense.
> 
> > With or without this patch, without ->cred_guard_mutex held we can race
> > with exec() and get the new ->mm but check old creds.
> > 
> > Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> 
> reasoning on the security check also makes sense.
> 
> Reviewed-by: Serge Hallyn <serue@xxxxxxxxxx>


Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next


-- 
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/