Re: [PATCH 1/2] UIO: add device clock support

[Paul Mundt]

On Wed, Jun 24, 2009 at 09:34:14AM -0700, Greg KH wrote:
> On Wed, Jun 24, 2009 at 05:30:24PM +0200, Daniel Mack wrote:
> > Add a pointer to a 'struct clk' to uio_info. Drivers can set
> > this pointer if a clock is needed, and the UIO core will care
> > to enable and disable it upon device open and release.
> 
> Do you have a UIO driver that needs this?
> 
> If so, please submit it at the same time, otherwise adding
> infrastructure for no driver that needs it, is pretty pointless.
> 
We can use this for the uio_pdrv_genirq case on sh, but open/release is a
bit coarse grained. Presently we default-enable clocks for devices that
are handled through uio, so doing it at open/release is at least better
than that. The other thing to consider is if we really want to add a
HAVE_CLK depdendency outright, or just ifdef around it..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/