Re: upcoming kerneloops.org item: get_page_from_freelist

[Linus Torvalds]

On Wed, 24 Jun 2009, Pekka Enberg wrote:
> 
> That said, I do think we ought to fix SLUB not to use __GFP_FAIL for
> the higher order allocation regardless of this patch.

I agree. Within the context of SLUB, it makes absolute sense.

That's especially true since SLUB already uses __GFP_NORETRY or whatever. 

The combination of __GFP_NOFAIL | __GFP_NORETRY is just insane. So your 
patch to remove __GFP_NOFAIL when adding __GFP_NORETRY is absolutely the 
ObviouslyCorrectThingToDo(tm).

Please integrate that, and take my patch too if you would (add my sign-off 
or just do your own version)? Or should I just apply them?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/