Re: PREEMPT_ACTIVE too low error with all asm-generic headers for some arches

From: Mike Frysinger
Date: Wed Jun 24 2009 - 18:21:39 EST


On Wed, Jun 24, 2009 at 11:02, Mike Frysinger wrote:
> On Wed, Jun 24, 2009 at 10:02, Arnd Bergmann wrote:
>> --- a/include/linux/hardirq.h
>> +++ b/include/linux/hardirq.h
>> @@ -62,6 +62,12 @@
>> Â#define HARDIRQ_OFFSET (1UL << HARDIRQ_SHIFT)
>> Â#define NMI_OFFSET Â Â (1UL << NMI_SHIFT)
>>
>> +#ifndef PREEMPT_ACTIVE
>> +#define PREEMPT_ACTIVE_BITS Â Â1
>> +#define PREEMPT_ACTIVE_SHIFT Â (NMI_SHIFT + NMI_BITS)
>> +#define PREEMPT_ACTIVE (__IRQ_MASK(PREEMPT_ACTIVE_BITS) << PREEMPT_SHIFT)
>
> i think you meant "<< PREEMPT_ACTIVE_SHIFT" there. Âonce i make that
> change, it builds fine.

and like Ingo, with that fix, add my Acked-by

thanks !
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/