Re: [PATCH -tip] perf_counter x86: fix cache_event_ids table

From: Jaswinder Singh Rajput
Date: Thu Jun 25 2009 - 08:01:46 EST


Hello Ingo,

On Thu, 2009-06-25 at 00:49 +0530, Jaswinder Singh Rajput wrote:
> On Thu, 2009-06-25 at 00:37 +0530, Jaswinder Singh Rajput wrote:
> > On Thu, 2009-06-25 at 00:25 +0530, Jaswinder Singh Rajput wrote:
> > > Fixed followings in cache_event_ids table without changing any
> > logic:
> > > 1. made it easier (3 dimension to 1 dimension array)
> > > 2. made more space for comments
> > > 3. decrease number of lines
> > > 4. fixed style problems
> > > 5. fixed 80 characters issues
> > >
> > > Style problems in arch/x86/kernel/cpu/perf_counter.c :
> > >
> > > Before :
> > > total: 492 errors, 32 warnings, 1713 lines checked
> > > After :
> > > total: 0 errors, 10 warnings, 1537 lines checked
> > >
> > > Fixed : 492 errors, 22 warnings and Reduced 176 lines.
> > >
> > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> >
> > Fixed some more issues:
> >
> > [PATCH] perf_counter x86: fix cache_event_ids table
>
> Fixed some more issues, and I am tired now going to bed :
>
> [PATCH] perf_counter x86: fix cache_event_ids table
>
> Fixed followings in cache_event_ids table without changing any logic:
> 1. made it easier (3 dimension to 1 dimension array)
> 2. make more space for comments
> 3. decrease number of lines
> 4. fixed style problems
> 5. fixed 80 characters issues
>
> Style problems in arch/x86/kernel/cpu/perf_counter.c :
>
> Before :
> total: 492 errors, 32 warnings, 1713 lines checked
> After :
> total: 0 errors, 10 warnings, 1537 lines checked
>
> Fixed : 492 errors, 22 warnings and Reduced 176 lines.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> ---
> arch/x86/kernel/cpu/perf_counter.c | 530 ++++++++++++------------------------
> 1 files changed, 177 insertions(+), 353 deletions(-)
>

I have tested this patch on AMD. Can you test it for Intel.

Thanks,
--
JSR


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/