Re: [PATCH 18/19] drivers/video: Use PCI_VDEVICE

[Joe Perches]

On Fri, 2009-06-26 at 12:54 +0300, Ville SyrjÃlà wrote:
> Perhaps there should be a PCI_VDDEVICE() or something for this type of
> stuff? Would make things even shorter.

drivers/edac/edac_core.h has:

#define PCI_VEND_DEV(vend, dev) PCI_VENDOR_ID_ ## vend, \
	PCI_DEVICE_ID_ ## vend ## _ ## dev

Try submitting a patch and see what happens...

> Also PCI_VDEVICE() does not use named initializers for some reason.
> Might be worth fixing.

Perhaps that's to avoid mixing named and unnamed initializers.

> It seems your script missed atyfb. It could use PCI_VDEVICE() too.

Can you show an example please?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/