Re: [PATCH 3/9] x86/moorestown: add moorestown platform flags

[Jesse Barnes]

On Fri, 26 Jun 2009 09:19:55 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:
> >  void platform_feature_init_default(int subarch_id)
> >  {
> > -	printk(KERN_INFO "Use default X86 platform feature set\n");
> > +	if ((subarch_id >= 0) && (subarch_id < N_X86_SUBARCHS)) {
> > +		if (subarch_id == X86_SUBARCH_MRST) {
> > +			setup_mrst_default_feature();
> > +			return;
> > +		}
> > +	} else {
> > +		printk(KERN_INFO "Use default X86 platform feature
> > set\n");
> > +	}
> >  }
> 
> Why dont we have some clean and robust PCI config space based 
> enumeration instead of this boot ID based thing?

MRST has special PCI support that depends on having the platform
identified already, so if you want to use something other than a flag
here, maybe we could use an SFI string instead.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/