Re: [PATCH] exec: Make do_coredump more robust and safer whenusing pipes in core_pattern

[Neil Horman]

On Thu, Jun 25, 2009 at 04:30:50PM -0700, Andrew Morton wrote:
<snip>

Ok, heres a new version of the changeset, taking into account all of your notes,
Andrew. Patches tested by me on a kernel with your latest -mm patch and it all
works well.

This resolves kernel.org bug 13355:
http://bugzilla.kernel.org/show_bug.cgi?id=13355

Change Notes:

1) Split the patch into two smaller patches.  I kept the sysctl with the wait
code for the reasons we discussed earlier.

2) core_dump_count is now statically declared within the scope of the
do_coredump function

3) Commented more clearly the use of the task_tgid_vnr call

4) Made the printk indicating that a crash is over the core dump limit more
usefull

5) Fixed some misc. gramatical, formatting errors

6) Removed the helper_pid variable.  Turns out it wasn't needed with a minor
change to the usermodehelper code.

7) Documented the sysctl in Documentation/sysctl/kernel.txt

Regards
Neil

Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
Reported-by: Earl Chew <earl_chew@xxxxxxxxxxx>
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/