Re: [PATCH] virtio_blk: add missing __dev{init,exit} markings

[Jesse Barnes]

On Wed, 20 May 2009 00:10:51 +0930
Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> On Mon, 18 May 2009 05:09:09 pm Mike Frysinger wrote:
> > -static int virtblk_probe(struct virtio_device *vdev)
> > +static int __devinit virtblk_probe(struct virtio_device *vdev)
> 
> This makes sense, I think, but then it implies that
> virtio_dev_probe() should also be __devinit, right?
> 
> And I look at pci_bus_probe(), and it's not __devinit.
> 
> Is the PCI code just slack?

I wouldn't be surprised if some annotations were missing or incorrect
given the churn in hotplug lately, but I can't find that particular
symbol...

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/