Re: [PATCH 9/9] x86/apic: support moorestown interrupt subsystem

[Eric W. Biederman]

"Pan, Jacob jun" <jacob.jun.pan@xxxxxxxxx> writes:

>>From 82d64ca4f963d2e205326534aff0c77d9bfa5858 Mon Sep 17 00:00:00 2001
> From: Jacob Pan <jacob.jun.pan@xxxxxxxxx>
> Date: Fri, 12 Jun 2009 02:16:05 -0700
> Subject: [PATCH] x86/apic: support moorestown interrupt subsystem
>
> This patch uses platform flags to selectively enable apic related setup
> code.
>
> Since moorestown does not have legacy timer or PIC, the only system
> timer irqs are routed via ioapic. Early timer ioapic enabling is also
> added to allow boot time timing services.

This patch is horribly wrong.   We should not have a moorestown specific
hack  we should not do early timer ioapic on everything that supports
it which is most x86 machines since apics became common.

At which point moorestown support should just be a little work somewhere
in the table parsers.

If you can't compile out the 8259 support code this has been factored
wrong. 

There are a handful of legacy systems with mptables that run in ioapic
mode yet use the timer and sometimes a couple of other devices on
the 8259 PIC.  Handling that case will complicate things a bit.

Hopefully it will be easier now to properly rework the code.  When
I tried it.  Linus's laptop died somewhere half way through bootup.
So we had to revert the support.

In summary if moorestown does not have an 8259 PIC it is time to remove
this long standing deficiency of the x86 ioapic code, not hack around
it.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/