Re: [tip:perfcounters/urgent] perf stat: Fix multi-run stats

[Ingo Molnar]

* Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx> wrote:

> On Sat, 2009-06-27 at 04:36 +0000, tip-bot for Ingo Molnar wrote:
> > Commit-ID:  566747e6298289c5cb02d4939cb3abf1c4fe7e5a
> > Gitweb:     http://git.kernel.org/tip/566747e6298289c5cb02d4939cb3abf1c4fe7e5a
> > Author:     Ingo Molnar <mingo@xxxxxxx>
> > AuthorDate: Sat, 27 Jun 2009 06:24:32 +0200
> > Committer:  Ingo Molnar <mingo@xxxxxxx>
> > CommitDate: Sat, 27 Jun 2009 06:34:37 +0200
> > 
> > perf stat: Fix multi-run stats
> > 
> > In multi-run (-r/--repeat) printouts, print out the noise of
> > the wall-clock average as well.
> > 
> > Also, fix a bug in printing out scaled counters: if it was not
> > scaled then we should not update the average with -1.
> > 
> > Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > Cc: Mike Galbraith <efault@xxxxxx>
> > Cc: Paul Mackerras <paulus@xxxxxxxxx>
> > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > LKML-Reference: <new-submission>
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> > 
> > 
> > ---
> >  tools/perf/builtin-stat.c |   15 +++++++++++----
> >  1 files changed, 11 insertions(+), 4 deletions(-)
> > 
> 
> 
> hmm, why you are keep on changing tools/perf/builtin-stat.c you 
> know my patches are in queue which I prepared on your request and 
> send pull request:
> 
> http://git.kernel.org/?p=linux/kernel/git/jaswinder/linux-2.6-tip.git;a=commitdiff;h=4e3340cd3087c4228350af04c2fc8f6502eb6ad6
> 
> In spite of adding the patches you keep on changing the original 
> file ??

Two things:

 - My changes and your changes do not conflict - i was able to
   apply your patches on top of my changes.

 - I could have applied all three patches of yours but i only
   applied the first one because the second and third did not
   implement the feature you are trying to add in an adequate
   way.

Also, i do not 'request' things from you, i am not your boss. I 
review patches and i reject patches i find inadequate. You are
free to submit new versions - or you are free to not do so. If
you submit new versions i will review them too and will merge
them or tell why i didnt merge them.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/