Re: [PATCH] acpi processor: simplify needlessly complex printk

[Justin P. Mattock]

Frans Pop wrote:
> Why use three printk statements if one will do?
>
> Signed-off-by: Frans Pop<elendil@xxxxxxxxx>
>
> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
> index 84e0f3c..b8fb74a 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -772,12 +772,11 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device)
>   	if (result)
>   		printk(KERN_ERR PREFIX "Create sysfs link\n");
>
> -	if (pr->flags.throttling) {
> -		printk(KERN_INFO PREFIX "%s [%s] (supports",
> -		       acpi_device_name(device), acpi_device_bid(device));
> -		printk(" %d throttling states", pr->throttling.state_count);
> -		printk(")\n");
> -	}
> +	if (pr->flags.throttling)
> +		printk(KERN_INFO PREFIX
> +			"%s [%s] (supports %d throttling states)\n",
> +			acpi_device_name(device), acpi_device_bid(device),
> +			pr->throttling.state_count);
>
>         end:
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>    
Would it be better to capitalize the S and add a period at the
end, or does it not matter?

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/