Re: [PATCH 1/2] MMC/pxamci: workaround regulator framework bugs

[Eric Miao]

Daniel Ribeiro wrote:
> Em Sáb, 2009-06-27 às 01:48 +0100, Mark Brown escreveu:
>>> +		/*
>>> +		 * When the bootloader leaves a supply active, it's
>>> +		 * initialized with zero usecount ... and we can't
>>> +		 * disable it without first enabling it.  Until the
>>> +		 * framework is fixed, we need a workaround like this
>>> +		 * (which is safe for MMC, but not in general).
>> This also needs to explain the actual situation, especially the
>> exclusivity reqirement of the MMC core.  It might be worth providing a
>> helper in the MMC core, everything is going to need to be updated to use
>> exclusive get whenever someone implements it.
> 
> Heh, this patch was copy-n-paste from twl code. I really can't put much
> time on this. :(
> 
>> As discussed at some length the regulator API is not going to be changed
>> in the way you demand.  This is not something that it should be easy for
>> standard consumers to do since for standard consumers it normally points
>> out a programming error.
> 
> Ok, so I will "fix it" hacking the bootloader to power off the voltage
> regulator before giving control to kernel. Lets hope that the next
> developer that tries to use the regulator framework with a mmc card and
> stumbles on the "regulator already enabled" case has more time to fix it
> properly. :)
> 

This looks to be running into the same issue as clocks - where for power
savings the clocks are assumed to be off as many as possible, leaving only
those essential ones enabled, yet the assumption of the boot loader does
this correctly is always a big problem, putting this into the kernel,
however, is ugly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/