Re: [PATCH 5/5] power_supply: add a charge_type status to the api,and use it for olpc driver

[Mark Brown]

On Tue, Jun 30, 2009 at 02:17:30AM -0400, Andres Salomon wrote:

> This adds a new sysfs file called 'charge_type' which displays the type of
> charging (n/a, trickle charge, slow charge, or fast charging).  This allows
> things like battery diagnostics to determine what the battery/EC is doing
> without resorting to changing the 'status' sysfs output.

> Signed-off-by: Andres Salomon <dilinger@xxxxxxxxxxxxxxx>

This looks good to me.  Could you please keep me on the CC for any
future revisions of this patch, I can make use of this in the WM8350
driver.

> +	static char *charge_type[] = {
> +		"N/A", "Trickle", "Slow", "Fast"
> +	};

I'd be tempted to make "N/A" be "Unknown" to match the style of the rest
of the attributes.  I'm also not sure that we need a slow type, but
equally it shouldn't do any harm.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/