Re: [PATCH] Makes slab pages field in show_free_areas() separate two field

[Minchan Kim]

On Tue, Jun 30, 2009 at 3:25 PM, KOSAKI
Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
> Subject: [PATCH] Makes slab pages field in show_free_areas() separate two field
>
> if OOM happed, We really want to know the number of rest reclaimable pages.
> Then, reclaimable slab and unreclaimable slab shouldn't be mixed displaing.

Yes. It makes sense to me.

>
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>

> ---
> Âmm/page_alloc.c | Â Â7 ++++---
> Â1 file changed, 4 insertions(+), 3 deletions(-)
>
> Index: b/mm/page_alloc.c
> ===================================================================
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2119,7 +2119,8 @@ void show_free_areas(void)
> Â Â Â Â Â Â Â Â" inactive_file:%lu"
> Â Â Â Â Â Â Â Â" unevictable:%lu"
> Â Â Â Â Â Â Â Â" dirty:%lu writeback:%lu unstable:%lu\n"
> - Â Â Â Â Â Â Â " free:%lu slab:%lu mapped:%lu pagetables:%lu bounce:%lu\n",
> + Â Â Â Â Â Â Â " free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n"
> + Â Â Â Â Â Â Â " mapped:%lu pagetables:%lu bounce:%lu\n",
> Â Â Â Â Â Â Â Âglobal_page_state(NR_ACTIVE_ANON),
> Â Â Â Â Â Â Â Âglobal_page_state(NR_ACTIVE_FILE),
> Â Â Â Â Â Â Â Âglobal_page_state(NR_INACTIVE_ANON),
> @@ -2129,8 +2130,8 @@ void show_free_areas(void)
> Â Â Â Â Â Â Â Âglobal_page_state(NR_WRITEBACK),
> Â Â Â Â Â Â Â Âglobal_page_state(NR_UNSTABLE_NFS),
> Â Â Â Â Â Â Â Âglobal_page_state(NR_FREE_PAGES),
> - Â Â Â Â Â Â Â global_page_state(NR_SLAB_RECLAIMABLE) +
> - Â Â Â Â Â Â Â Â Â Â Â global_page_state(NR_SLAB_UNRECLAIMABLE),
> + Â Â Â Â Â Â Â global_page_state(NR_SLAB_RECLAIMABLE),
> + Â Â Â Â Â Â Â global_page_state(NR_SLAB_UNRECLAIMABLE),
> Â Â Â Â Â Â Â Âglobal_page_state(NR_FILE_MAPPED),
> Â Â Â Â Â Â Â Âglobal_page_state(NR_PAGETABLE),
> Â Â Â Â Â Â Â Âglobal_page_state(NR_BOUNCE));
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>



-- 
Kinds regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/