Re: mmotm 2009-06-30-12-50 uploaded

[Valdis . Kletnieks]

On Tue, 30 Jun 2009 16:15:52 EDT, Valdis.Kletnieks@xxxxxx said:
>
> Yowza.  Not sure what makes it think there's an issue at line 20, looks to
> *me* like the actual patch starts on line 77.

>From the patch:

A sample output of /proc/<pid>/task/<tid>/maps looks like:

08048000-08049000 r-xp 00000000 03:00 8312       /opt/z
08049000-0804a000 rw-p 00001000 03:00 8312       /opt/z
0804a000-0806b000 rw-p 00000000 00:00 0          [heap]
a7d12000-a7d13000 ---p 00000000 00:00 0
a7d13000-a7f13000 rw-p 00000000 00:00 0          [thread stack: 001ff4b4]
a7f13000-a7f14000 ---p 00000000 00:00 0

The line with '[heap]' gives it the indigestion - deleting that line and
we get:

% quilt push procfs-provide-stack-information-for-threads-v08.patch
Applying patch procfs-provide-stack-information-for-threads-v08.patch
patching file Documentation/filesystems/proc.txt
patching file fs/exec.c
Hunk #1 succeeded at 1340 (offset -4 lines).
patching file fs/proc/array.c
patching file fs/proc/task_mmu.c
patching file include/linux/sched.h
Hunk #1 succeeded at 1486 (offset 26 lines).
patching file kernel/fork.c
Hunk #1 succeeded at 1094 (offset -1 lines).

Now at patch procfs-provide-stack-information-for-threads-v08.patch

Not sure why that line did it.  Repeated truncate-and-try shows that if the
line contained just the 4 chars '0804', it applied fine, but '0804a' dies.

<Cue twilight zone theme>,

Attachment: pgp00000.pgp
Description: PGP signature