Re: [PATCH -tip 3/3] kprobes: cleanup: use list instead of hlistfor insn_pages

From: Ingo Molnar
Date: Tue Jun 30 2009 - 17:25:56 EST



* Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> Use struct list instead of struct hlist for managing insn_pages,
> because insn_pages doesn't use hash table.

> struct kprobe_insn_page {
> - struct hlist_node hlist;
> + struct list_head list;

Hm, you know that this increases the size of kprobe_insn_page by 4/8
bytes, right?

hlists are not just used for hashes - but also when we want a more
compact / smaller list head.

How many kprobe_insn_page's can be allocated in the system,
maximally?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/