Re: [PATCH] FRV: Wire up new syscalls

[Ingo Molnar]

* Arnd Bergmann <arnd@xxxxxxxx> wrote:

> On Tuesday 30 June 2009, Ingo Molnar wrote:
> > * David Howells <dhowells@xxxxxxxxxx> wrote:
> > 
> > > Wire up new syscalls rt_tgsigqueueinfo and perf_counter_open.
> > 
> > > +     .long sys_perf_counter_open
> > 
> > Hm, i suspect this should be sys_ni because FRV does not set 
> > HAVE_PERF_COUNTERS so perfcounters cannot be enabled. (Or do you 
> > have patches in the pipeline that enable perfcounters for FRV?)
> 
> It doesn't matter because of the cond_syscall() in 
> kernel/sys_ni.c. Right now, scripts/checksyscalls.sh causes a 
> warning on each architecture that does not assign a system call 
> number for sys_perf_counter_open, so they might as well make it 
> point to sys_ni though cond_syscall().

It would make sense to wire it up for real as it's really easy: just 
set HAVE_PERF_COUNTERS in arch/frv/Kconfig, add an empty 
arch/frv/include/asm/perf_counter.h file. (Optional: double check 
that tools/perf/ builds and works fine on FRV ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/