Re: [PATCH 2/8] SFI: include/linux/sfi.h

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, 23 Jun 2009 09:28:11 +0200
> Ingo Molnar <mingo@xxxxxxx> wrote:
> 
> > > +/*
> > > + * Table structures must be byte-packed to match the SFI specification,
> > > + * as they are provided by the BIOS.
> > > + */
> > > +#pragma pack(1)
> > 
> > We use __attribute__((packed)) for that generally.
> 
> Or __packed.  I usually recommend __packed because I can never 
> remember the weird arrangement of underscores and parentheses in 
> the gcc thing.

Agreed - it's also shorter and more in line with stuff like 
__read_mostly, etc.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/