Re: [PATCH] FAT: optimize FSINFO writeback

[Steven J. Magnani]

On Wed, 2009-07-01 at 05:57 +0900, OGAWA Hirofumi wrote:
> steve@xxxxxxxxxxxxxxx writes:
> 
> > Only write the FSINFO block back to disk when its contents change.
> > This optimization can be important when the underlying physical media
> > can wear out, i.e. Flash.
> 
> I have no objection to this though.  Was this tested on recent version?

I tested it on 2.6.30.

> Well, now, we are using sb->s_dirty for fsinfo, so I'm wondering why
> this happen frequently.

My scenario was modifying a sector of an existing file and using
fdatasync() to flush it. The FSINFO sector was being updated even though
nothing about the FAT layout had changed.

> 
> Thanks.

Regards,
------------------------------------------------------------------------
 Steven J. Magnani               "I claim this network for MARS!
 www.digidescorp.com              Earthling, return my space modulator!"

 #include <standard.disclaimer>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/