Re: [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bitx86

From: H. Peter Anvin
Date: Tue Jun 30 2009 - 18:56:38 EST


Yinghai Lu wrote:
>>>
>>> Not very well tested, but it _looks_ correct, and uses Peter's trick, and
>>> willlet the compiler notice that
>>>
>>> round_up(x,y)-1
>>>
>>> is the same thing as
>>>
>>> x | (y-1)
>>>
>>> which it _could_ have perhaps figured out before, but now it's way more
>>> obvious.
>> how about x = 0, y = 0x100?
>>
>
> also x=0x100000, and y=0x100?
>

Yes, it doesn't work when x is already aligned.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/