Re: [PATCH v1 6/6][ARM] new ARM SoC support: BCMRing

[Alan Cox]

On Tue, 30 Jun 2009 20:41:01 +0200
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> wrote:

> On 16:30 Fri 26 Jun     , Leo (Hao) Chen wrote:
> > Hi,
> > 
> > The last patch. This big patch includes the minimal set of our CSP (chip support package), which is our OS independent chip supporting code and headers.  All the codes are under arch/arm/mach-bcmring directory.
> This patch is unreadable
> you need
> 1) Respect the Linux coding Style

For an OS independant set of chip support defines that usually makes no
sense

> 2) to split in small changeset

For a new submission that generally doesn't make much sense either - not
for all the new files stuff.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/