Re: [PATCH] Show kernel stack usage to /proc/meminfo and OOM log

[KOSAKI Motohiro]

> On Tue, 30 Jun 2009, KOSAKI Motohiro wrote:
> 
> > +static void account_kernel_stack(struct thread_info *ti, int on)
> 
> static inline?

gcc automatically inlined, IMHO.

> > +{
> > +	struct zone* zone = page_zone(virt_to_page(ti));
> > +	int sign = on ? 1 : -1;
> > +	long acct = sign * (THREAD_SIZE / PAGE_SIZE);
> 
> int pages = THREAD_SIZE / PAGE_SIZE;
> 
> ?

Will fix. thanks cleaner code advise.

> 
> > +
> > +	mod_zone_page_state(zone, NR_KERNEL_STACK, acct);
> 
> mod_zone_page_state(zone, NR_KERNEL_STACK, on ? pages : -pages);

yes, will fix.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/