RE: [PATCH v1 6/6][ARM] new ARM SoC support: BCMRing

[Scott Branden]

Alan,

We would really like to know what needs to change in our patchset.  We have a large codebase of drivers for multiple chipsets already written that we have been maintaining internally and releasing for customer development.  For code that patches existing linux code we follow the style dictated in those files.  But for our new code we do not.

For our new code we have many developers who have written the code and thus a few "linux standard" coding styles have not been followed.  Much driver code is split into an os-less portion and a linux wrapper portion.  People have written following ISO/IEC 9899:1999 coding which allows such things as // comments.  Also using tabs in our code is not a requirement.  

My question is do we need to change our entire codebase over to match linux coding standards for comments and whitespace so it can pass a checkpatch script?  I'm sure there is a standard linux kernel community response to this but I need to forward that answer (whatever it is) to our many developers so we know what it is required to get our existing code integrated into the standard linux kernel.

Thanks,
 Scott


-----Original Message-----
From: linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxxxxx [mailto:linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxxxxx] On Behalf Of Alan Cox
Sent: June 30, 2009 4:21 PM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: Leo (Hao) Chen; linux-arm-kernel@xxxxxxxxxxxxxxxxxxxxxx; Linux Kernel
Subject: Re: [PATCH v1 6/6][ARM] new ARM SoC support: BCMRing

On Tue, 30 Jun 2009 20:41:01 +0200
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> wrote:

> On 16:30 Fri 26 Jun     , Leo (Hao) Chen wrote:
> > Hi,
> > 
> > The last patch. This big patch includes the minimal set of our CSP (chip support package), which is our OS independent chip supporting code and headers.  All the codes are under arch/arm/mach-bcmring directory.
> This patch is unreadable
> you need
> 1) Respect the Linux coding Style

For an OS independant set of chip support defines that usually makes no sense

> 2) to split in small changeset

For a new submission that generally doesn't make much sense either - not for all the new files stuff.


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/