Re: [PATCH] gpiolib: allow exported GPIO nodes to be named using sysfs links

[David Brownell]

On Monday 22 June 2009, Andrew Morton wrote:
> On Thu, 11 Jun 2009 12:19:03 +0300
> Jani Nikula <ext-jani.1.nikula@xxxxxxxxx> wrote:
> 
> > +int gpio_export_link(struct device *dev, const char *name, unsigned gpio)
> > +{
> > +	struct gpio_desc	*desc;
> > +	int			status = -EINVAL;
> > +
> > +	BUG_ON(dev == NULL);
> > +	BUG_ON(name == NULL);
> 
> We usually don't bother with these assertions.  If the kernel will
> reliably oops if one of these is NULL, then that provides the same
> information anyway.

Yeah, it'd be better to remove those BUG_ON() things before this goes upstream...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/