RE: [PATCH] OMAP: HSMMC: Do not enable buffer ready interrupt ifusing DMA

[Gadiyar, Anand]

On Fri, May 22, 2009, Gadiyar, Anand wrote:
> On Wed, May 06, 2009, Gadiyar, Anand wrote:
> > On Tue, May 5, 2009, Jarkko Lavinen wrote: 
> > > On Tue, Apr 21, 2009 at 09:39:22AM +0200, ext Gadiyar, Anand wrote:
> > > > From: Anand Gadiyar <gadiyar@xxxxxx>
> > > > 
> > > > OMAP: HSMMC: Do not enable buffer ready interrupt if using DMA
> > > > 
> > > > This considerably reduces the number of interrupts during a transfer
> > > > and ought to result in some power saving.
> > > 
> > > I tried the patch with reading from the raw mmc block device to
> > > /dev/null with dd (with bs 32k and 1M).  I cannot see any
> > > difference in interrupt count from /proc/interrupts or in read
> > > speed. At least the patch works. Cpu was 34340es3.
> > > 
> > > I also trid without the patch just disabling the Buffer
> > > Read/write Ready bits from INT_EN_MASK which is then written to
> > > both MMCHS_IE and MMCHS_ISE.  Still no change in read speed nor
> > > mmc irq count.
> > > 
> > > Cheers
> > > Jarkko Lavinen
> > 
> > I discovered this while doing MMC writes. I did not check if there
> > was any difference during a read. I notice you have only tested with
> > MMC reads.
> > 
> > Here's what I get with and without the patch.
> > 
> > - Anand
> 
> 
> Any comments on this? Is it safe to merge?
> 
> Thanks,
> Anand

<snip>


Ping?

Patchwork link is:
http://patchwork.kernel.org/patch/19133/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/