Re: [Patch 1/3] elf: fix one check-after-use

[James Morris]

On Wed, 1 Jul 2009, Amerigo Wang wrote:

> 
> Check before use it.
> 
> Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
> Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: David Howells <dhowells@xxxxxxxxxx>

Probably needs to go into Linus' tree and stable.


Acked-by: Roland McGrath <roland@xxxxxxxxxx>
Acked-by: James Morris <jmorris@xxxxxxxxx>

> 
> ---
> Index: linux-2.6/fs/binfmt_elf.c
> ===================================================================
> --- linux-2.6.orig/fs/binfmt_elf.c
> +++ linux-2.6/fs/binfmt_elf.c
> @@ -1522,11 +1522,11 @@ static int fill_note_info(struct elfhdr 
>  	info->thread = NULL;
>  
>  	psinfo = kmalloc(sizeof(*psinfo), GFP_KERNEL);
> -	fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);
> -
>  	if (psinfo == NULL)
>  		return 0;
>  
> +	fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);
> +
>  	/*
>  	 * Figure out how many notes we're going to need for each thread.
>  	 */
> 

-- 
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/