RE: Problem with /proc/iomem on ARM

[H Hartley Sweeten]

On Wednesday, July 01, 2009 10:55 AM, Kay Sievers wrote:
> On Wed, Jul 1, 2009 at 19:32, H Hartley wrote:
>> I just noticed a problem with /proc/iomem on my ARM system
>> that I think was introduced by your patch:
>>
>> commit 1d559e29138834bbcdf34ac072232bf543bfc4e0
>> Author: Kay Sievers <kay.sievers@xxxxxxxx>
>> Date: Â Tue Jan 6 10:44:43 2009 -0800
>>
>> Â Âarm: struct device - replace bus_id with dev_name(), dev_set_name()
>>
>> Â ÂCc: Russell King <rmk@xxxxxxxxxxxxxxxx>
>> Â ÂSigned-off-by: Kay Sievers <kay.sievers@xxxxxxxx>
>> Â ÂSigned-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
>> This was seen with kernel 2.6.30. ÂI havn't looked at /proc/iomem for
>> a while so I'm not sure when this first started.
>
> Are you sure, 8a577ffc75d9194fe8cdb7479236f2081c26ca1f isn't in your tree?

That commit is in my tree.  It appears that commit only fixes pci devices.
The serial ports on my system are amba bus devices.

> After all, it seems like this should be fixed in arm somewhere, not to
> copy and store internal driver core pointers, but use the device
> itself to retrieve the values.

Maybe the problem is in drivers/amba/bus.c? amba_device_register() does:

	dev->res.name = dev_name(&dev->dev);

But there is nothing in the code about setting the kobj.

Regards,
Hartley
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðÃnÆàþY&—