[PATCH, v2] x86: Fix printk call in print_local_apic()
From: Ingo Molnar
Date: Thu Jul 02 2009 - 02:29:25 EST
* Ingo Molnar <mingo@xxxxxxx> wrote:
>
> > - printk(KERN_DEBUG "0123456789abcdef0123456789abcdef\n" KERN_DEBUG);
> > + printk(KERN_DEBUG "0123456789abcdef0123456789abcdef\n");
> > for (i = 0; i < 8; i++) {
> > + char bin[33];
> > v = apic_read(base + i*0x10);
> > +
> > + /* Do we really want to print out LSB first? */
>
> We definitely want MSB first - i'll flip around the order.
in fact i dont remember ever having relied on the bitfield nature of
that printout. Since this is uncommon debug code, printing the plain
hexa value is more than enough.
In fact we can compact it down to a single line:
0123456701234567012345670123456701234567012345670123456701234567
instead of 4 lines of bitfields.
So i've done the patch below that looks quite a bit simpler. Mind
testing it, does it fix all the printout artifacts you've seen?
Ingo
------------------>