[PATCH, v4] x86: Fix printk call in print_local_apic()

From: Ingo Molnar
Date: Thu Jul 02 2009 - 02:59:52 EST



* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, 2 Jul 2009 08:28:47 +0200 Ingo Molnar <mingo@xxxxxxx> wrote:
>
> > + printk(KERN_CONT "%08x", i, apic_read(base + i*0x10));
>
> oop - compile it first ;)

oops - v4 below ...

> There was some talk about teaching the lib/hexdump.c code to be
> able to take a caller-provided give-me-another-byte function
> pointer. This is the first potential user of such a thing which I
> recall seeing, so it's probably good that we didn't do it ;)

This at most has 'give me another 4 bytes' - plus there's some
indexing weirdness as well. (the bitfield is holey in the MSR range)

Dunno. Once the facility is available this code can be updated to
use it, although it's certainly obvious enough in its current form
already.

Ingo

------------------->