Re: [PATCH] ubifs: allow more than one volume to be mounted

[Daniel Mack]

On Thu, Jul 02, 2009 at 06:17:45PM +0300, Artem Bityutskiy wrote:
> Daniel Mack wrote:
>> UBIFS uses a bdi device per volume, but does not care to hand out unique
>> names to each of them. This causes an error when trying to mount more
>> than one volumes.
>>
>> [  239.277407] kobject_add_internal failed for ubifs with -EEXIST, don't try to register things with the same name in the same directory.
>> [  239.289618] [<c002a45c>] (unwind_backtrace+0x0/0xdc) from [<c0160628>] (kobject_add_internal+0x188/0x1b8)
>> [  239.299445] [<c0160628>] (kobject_add_internal+0x188/0x1b8) from [<c01607d8>] (kobject_add+0x48/0x5c)
>> [  239.308896] [<c01607d8>] (kobject_add+0x48/0x5c) from [<c019d96c>] (device_add+0xac/0x510)
>> [  239.317392] [<c019d96c>] (device_add+0xac/0x510) from [<c019de58>] (device_create_vargs+0x70/0xa4)
>> [  239.326589] [<c019de58>] (device_create_vargs+0x70/0xa4) from [<c0073138>] (bdi_register+0x44/0x64)
>> [  239.335854] [<c0073138>] (bdi_register+0x44/0x64) from [<c01249f0>] (ubifs_get_sb+0x3c8/0x10cc)
>> [  239.344769] [<c01249f0>] (ubifs_get_sb+0x3c8/0x10cc) from [<c008b054>] (vfs_kern_mount+0x50/0xa8)
>> [  239.353867] [<c008b054>] (vfs_kern_mount+0x50/0xa8) from [<c008b0f0>] (do_kern_mount+0x34/0xd0)
>> [  239.362799] [<c008b0f0>] (do_kern_mount+0x34/0xd0) from [<c009f7b4>] (do_mount+0x644/0x6b4)
>> [  239.371377] [<c009f7b4>] (do_mount+0x644/0x6b4) from [<c009f8a8>] (sys_mount+0x84/0xcc)
>> [  239.379538] [<c009f8a8>] (sys_mount+0x84/0xcc) from [<c0025e80>] (ret_fast_syscall+0x0/0x2c)
>>
>> Append the UBI volume and device ID to avoid that.
>>
>> Signed-off-by: Daniel Mack <daniel@xxxxxxxx>
>> Cc: Artem Bityutskiy <dedekind@xxxxxxxxxxxxx>
>> Cc: Adrian Hunter <ext-adrian.hunter@xxxxxxxxx>
>> Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
>
> Thanks, I'll look at this tomorrow and try to sent it to Linus
> ASAP.

Btw - Adrian Hunter's email in MAINTAINERS seems to be outdated:

<ext-adrian.hunter@xxxxxxxxx>: host mx1.nokia.com[192.100.122.228] said:
550 5.1.1 <ext-adrian.hunter@xxxxxxxxx>... User unknown (in reply to RCPT TO command)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/