Re: PROPOSAL: extend pipe() to support NULL argument.

[Changli Gao]

On Fri, Jul 3, 2009 at 5:42 PM, Amerigo Wang<xiyou.wangcong@xxxxxxxxx> wrote:
>>I said: It just a special case. Fixing sendfile() won't fix everything.
>
> What do you want? Just saving an fd, isn't it?
>
> sendfile() does this but you said it's buggy, if you fix it, what is the
> rest problem?
>
You should know why Linux invented splice(2). Not all of the problems
can be solved by sendfile(2).

>>
>>In fact, sendfile(2) is implemented via splice(2) infrastructure. The
>>logic is the same, and much clever than yours. Dive into its code, you
>>will find the reason why it must be blocked on outfd.
>
>
> Sure, this is done in user-space, definitely....
>
Did you review the code of sendfile(2)? If so, you will know the
common problem.If the data buffered in pipe can't be sent by one
splice(2) call, there are two ways:
1. reserve this pipe to reserve the data in it.
2. block on splice(pipe, outfd) until all the data in it is sent.
and sendfile(2) chooses this second one. In fact, there is  another
choice: simply close the pipe, and the data in the pipe is lost
forever. It isn't a choice, is it?

>>
>>It isn't splice(2)'s fault. In fact, I can also work around this issue
>>by named pipe.
>
> And increase the max fd number...
>
Yea, in many cases, max fd number must be enlarged. More fds means
more memory. Although memory is cheaper today, we have to do our best
to save money.


-- 
Regardsï
Changli Gao(xiaosuo@xxxxxxxxx)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/