Re: [PATCH] vt: add an event interface

[Jaswinder Singh Rajput]

On Fri, 2009-07-03 at 18:42 +0200, Ingo Molnar wrote:
> * Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > A good example of what happens if you don't is
> > 
> > scripts/checkpatch.pl --file arch/x86/kernel/cpu/mtrr/*c
> > 
> > where the core part of the code isn't changed very much even 
> > though the interfaces completely get reworked. Thus it never gets 
> > cleaned up and reviewed as a whole. The code works, will probably 
> > work for years but never gets looked at as a whole and tidied.
> 
> I think even the MTRR code (which is indeed one of the few x86 
> places still not fully cleaned up) supports my arguments.
> 
> Look at the averages:
> 
>                                       errors   lines of code   errors/KLOC
> arch/x86/kernel/cpu/mtrr/amd.c             2             120          16.6
> arch/x86/kernel/cpu/mtrr/centaur.c         8             225          35.5
> arch/x86/kernel/cpu/mtrr/cleanup.c         0            1102             0
> arch/x86/kernel/cpu/mtrr/cyrix.c          10             275          36.3
> arch/x86/kernel/cpu/mtrr/generic.c        16             730          21.9
> arch/x86/kernel/cpu/mtrr/if.c             11             428          25.7
> arch/x86/kernel/cpu/mtrr/main.c           50             751          66.5
> arch/x86/kernel/cpu/mtrr/state.c           0              83             0
> 
> The arch/x86/kernel/cpu/mtrr/cleanup.c file is a new bit and 
> relatively clean.
> 

I will fix these ASAP ;-)

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/