Re: [PATCH 2/5] sparc: use asm-generic/dma-mapping-common.h

[Arnd Bergmann]

On Monday 06 July 2009, FUJITA Tomonori wrote:
> +static inline struct dma_map_ops *get_dma_ops(struct device *dev)
> +{
> +       return dma_ops;
> +}
> +
> +#define flush_write_buffers()
> +
> +#include <asm-generic/dma-mapping-common.h>

I still think the flush_write_buffers() x86-ism should not be required
to use dma-mapping-common.h and only be used in arch/x86/kernel/pci-nommu.c
so you don't have to add dummy definitions to all architectures.

See http://lkml.org/lkml/2009/6/30/134

Otherwise, your series looks good!

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/