Re: [BUG] drivers/video/sis: deadlock introduced by"fbdev: add mutex for fb_mmap locking"

[Krzysztof Helt]

On Mon, 06 Jul 2009 09:13:11 +0800
Wu Zhangjin <wuzhangjin@xxxxxxxxx> wrote:

> Hi,
> 
> 
> This patch also works for me, thanks!
> 
> Regards,
> Wu Zhangjin
> 

Who should I send this patch to be included as a 2.6.31 regression fix?

Regards,
Krzysztof

> > 
> > From: Krzysztof Helt <krzysztof.h1@xxxxx>
> > 
> > Remove redundant call to the sisfb_get_fix() before sis frambuffer is registered.
> > 
> > This fixes a problem with uninitialized the fb_info->mm_lock mutex.
> > 
> > Signed-off-by: Krzysztof Helt <krzysztof.h1@xxxxx>
> > ---
> > 
> > diff -urp linux-ref/drivers/video/sis/sis_main.c linux-next/drivers/video/sis/sis_main.c
> > --- linux-ref/drivers/video/sis/sis_main.c	2009-07-01 18:07:05.000000000 +0200
> > +++ linux-next/drivers/video/sis/sis_main.c	2009-07-05 17:20:33.000000000 +0200
> > @@ -6367,7 +6367,6 @@ error_3:	vfree(ivideo->bios_abase);
> >  		sis_fb_info->fix = ivideo->sisfb_fix;
> >  		sis_fb_info->screen_base = ivideo->video_vbase + ivideo->video_offset;
> >  		sis_fb_info->fbops = &sisfb_ops;
> > -		sisfb_get_fix(&sis_fb_info->fix, -1, sis_fb_info);
> >  		sis_fb_info->pseudo_palette = ivideo->pseudo_palette;
> >  
> >  		fb_alloc_cmap(&sis_fb_info->cmap, 256 , 0);
> > 
> > 
> > 
> > ----------------------------------------------------------------------
> > Najlepsze OC i AC tylko w Ergo Hestia
> > http://link.interia.pl/f222
> > 
> 
> 

----------------------------------------------------------------------
Najlepsze OC i AC tylko w Ergo Hestia
http://link.interia.pl/f222

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/