Re: [PATCH] Remove multiple KERN_ prefixes from printk formats

[Joe Perches]

On Mon, 2009-07-06 at 16:23 -0400, Mike Frysinger wrote:
> thanks, i had started this in the Blackfin code a little, but your
> patch includes what i did and more, so the Blackfin stuff should be
> mostly fine (pending comments below).
[]
> > -       printk(KERN_EMERG "\n" KERN_EMERG "Double Fault\n");
> > +       printk(KERN_EMERG "Double Fault\n");
> 
> dropped a newline.  we've largely made sure the newlines and such were
> as we want in the output ... in this case, it is not a matter of
> adding a newline where one did not exist before

Hi Mike.

I'm of the opinion that blank lines in the log file
aren't very useful, but as you like, it's your code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/