Re: [PATCH] Remove multiple KERN_ prefixes from printk formats

[Joe Perches]

On Mon, 2009-07-06 at 13:33 -0700, Linus Torvalds wrote:
> 
> On Mon, 6 Jul 2009, Mike Frysinger wrote:
> > >  #ifdef CONFIG_DEBUG_VERBOSE
> > > -       printk(KERN_EMERG "\n" KERN_EMERG "Double Fault\n");
> > > +       printk(KERN_EMERG "Double Fault\n");
> > 
> > dropped a newline.  we've largely made sure the newlines and such were
> > as we want in the output ... in this case, it is not a matter of
> > adding a newline where one did not exist before
> 
> Note that the 'printk' itself will add a required newline these days.
> 
> So unless you want an _empty_ line due to an earlier '\n', the change is 
> correct.

Note the prefix before and after the "\n"
I believe he _wants_ an empty line.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/