Re: [KVM PATCH v9 2/2] KVM: add iosignalfd support

[Gregory Haskins]

Avi Kivity wrote:
> (adding Davide, there's a small comment for you in the middle, search
> for eventfd)
>
> On 07/07/2009 02:20 PM, Michael S. Tsirkin wrote:
>>
>>> @@ -307,6 +307,19 @@ struct kvm_guest_debug {
>>>       struct kvm_guest_debug_arch arch;
>>>   };
>>>
>>> +#define KVM_IOSIGNALFD_FLAG_TRIGGER   (1<<  0) /* trigger is valid */
>>>      
>>
>> can we rename trigger ->  value?
>>    
>
> Or maybe data_match?

Yeah, at the least I should be consistent with trigger/match
>
> Speaking of renames, how about IOSIGNALFD -> IOEVENTFD?  I have some
> vague uneasiness seeing signals all the time.

Sure, that works for me.

-Greg

Attachment: signature.asc
Description: OpenPGP digital signature