Re: [PATCH 1/8] ksym_tracer: Extract trace entry from struct trace_ksym

[Li Zefan]

>> -	entry = ring_buffer_event_data(event);
>> +	entry		= ring_buffer_event_data(event);
>> +	entry->ip	= instruction_pointer(regs);
>> +	entry->type	= hbp->info.type;
>>  	strlcpy(entry->ksym_name, hbp->info.name, KSYM_SYMBOL_LEN);
>> -	entry->ksym_hbp = hbp;
>> -	entry->ip = instruction_pointer(regs);
>> -	strlcpy(entry->p_name, current->comm, TASK_COMM_LEN);
>> +	strlcpy(entry->cmd, current->comm, TASK_COMM_LEN);
> 
> 
> Ah, I did not realized that the cmdline was that roughly saved.
> It would be more ring-buffer-friendly to use tracing_record_cmdline.
> 

Yeah, I'll send an incremental patch later.

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/