Re: [RFC][PATCH] flexible array implementation

From: Denys Vlasenko
Date: Tue Jul 21 2009 - 12:57:57 EST


On Tue, Jul 21, 2009 at 6:03 PM, Dave Hansen<dave@xxxxxxxxxxxxxxxxxx> wrote:
> +static inline struct flex_array_part *
> +__fa_get_part(struct flex_array *fa, int part_nr, gfp_t flags)
> +{
> +       struct flex_array_part *part = NULL;
> +       if (part_nr > __nr_part_ptrs())
> +               return NULL;
> +       part = fa->parts[part_nr];
> +       if (!part) {
> +               part = kmalloc(FLEX_ARRAY_PART_SIZE, flags);
> +               if (!part)
> +                       return NULL;
> +               fa->parts[part_nr] = part;
> +       }
> +       return part;
> +}

This is far too big to be an inline.

--
vda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/