Re: [PATCH] cgroup: fix reverse unlock sequence in cgroup_get_sb

[Danny Feng]

This is a multi-part message in MIME format.On 07/22/2009 12:03 AM, Paul Menage wrote:
> On Tue, Jul 21, 2009 at 3:25 AM, Xiaotian Feng<dfeng@xxxxxxxxxx>  wrote:
> > In cgroup_get_sb, the lock sequence is:
> >         mutex_lock(&inode->i_mutex);
> >         mutex_lock(&cgroup->mutex);
> > so the last unlock sequence should be:
>
> Make this "so for consistency the last ..." ?
>
> Maybe make the patch title "Make unlock sequence in cgroup_get_sb
> consistent" so someone looking through the change logs for fixes to
> backport doesn't wrongly thing that this fixes any bug"?

Yep, this is a trivial patch.  Modified following your suggestion, thank 
you.

> >         mutex_unlock(&cgroup->mutex);
> >         mutex_unlock(&inode->i_mutex);
> >
> > Signed-off-by: Xiaotian Feng<dfeng@xxxxxxxxxx>
>
> Acked-by: Paul Menage<menage@xxxxxxxxxx>
>
> Paul